Added a simple example for the set path - #20
Conversation
📝 WalkthroughWalkthroughThe PR updates Sims 4 Archipelago setup docs: clarifies manual path entry (do not include quotes), adds a Windows example path, and advises that an existing save can be used but recommends a fresh save per run, noting potential issues when reusing the same save. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @worlds/sims4/docs/setup_en.md:
- Line 27: Replace the typo "dont" with the contraction "don't" in the sentence
"If you have to manually set the path make sure you dont include quotes in the
path" (edit that exact sentence in worlds/sims4/docs/setup_en.md so it reads "If
you have to manually set the path make sure you don't include quotes in the
path").
- Line 28: Clarify that the provided example path "/set_path
C:/Users/User/Documents/Electronic Arts/The Sims 4/Mods" is Windows-specific by
appending a platform label (e.g., "(Windows)") and/or add equivalent example
paths for macOS and Linux (e.g., a macOS example like "/set_path
/Users/username/Documents/Electronic Arts/The Sims 4/Mods" and a Linux example
like "/set_path /home/username/.local/share/The Sims 4/Mods") so readers on
other platforms immediately see the correct format.
📜 Review details
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
worlds/sims4/docs/setup_en.md
🔇 Additional comments (1)
worlds/sims4/docs/setup_en.md (1)
32-33: Good addition to script mods guidance.The clarification about using a fresh save for each run and the note about potential issues with save reuse is helpful and well-integrated. This provides users with practical recommendations to avoid frustration.
Clarify instructions for setting the Mods folder path and specify the operating system in the example.
|
Are you in the main Archipelago discord server? I don't think I've seen you around before, but that's not an issue. How did you find this project? |
|
If you're able, could you consider adding an example path to the client as well? It'd be under I believe editing the docstring on that function is sufficient, however I'd have to get back to you on that. |
|
I also fixed a couple of things code rabbit pointed out, but honestly I don't know if I want it to review docs or not, so I might change the settings a bit. |
* Improve the docs * Added an example * fix styling/typo * Update setup instructions for Mods folder path Clarify instructions for setting the Mods folder path and specify the operating system in the example. --------- Co-authored-by: Benny D <78334662+benny-dreamly@users.noreply.github.com>
Just added an example for the set_path command
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.