add fallback environment variables for database and port#66
Open
lover3123 wants to merge 1 commit into
Open
Conversation
Owner
|
solve merge conflicts @lover3123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
backend/server.jsfile relies strictly on a local.envfile for configuration. If this file is missing (e.g., during new developer onboarding or in fresh cloud deployments), the application throws an unhandled extraction exception and crashes.This PR introduces reliable, safe fallback bindings using short-circuit operators (
||) to ensure the server can boot cleanly even without an explicit.envfile.Changes Made
backend/server.jsto include fallback defaults forPORTandMONGO_URL.mongoose.connect()function to utilize the securely definedMONGO_URLvariable.app.listen()block dynamically uses the resolvedPORT.Testing Instructions
Verified the fallback behavior locally:
.envto.env.backup.5000and connected tomongodb://127.0.0.1:27017/school_websitewithout throwing undefined variable errors.Related Issues
Fixes #28
Checklist
Contributing.mdguidelines.