<sc-editingscripts /> nullreference #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Removed throwing an error and rendering nothing instead for <sc-editingscripts /> when no ISitecoreRenderingContext is available
robearlam
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
In case of Experience Edge unavailability the ISitecoreRenderingContext might be empty, there is no reason to throw an exception and crash the page from rendering. This tag is often used in a main layout (like it was on MVP Website) which is also used when rendering error pages without a Sitecore context. Having this tag helper on the page causes issues in such case while it's perfectly acceptable to have an empty result.
Testing
Terms