[create-sitecore-jss] Replace sass-alias with Next.js 16 compatible importer #2179
+109
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Exclude Node.js built-in modules from client bundle | ||
| // This is needed for plugins that use Node.js modules (e.g., sass plugin with fs) | ||
| if (!isServer) { | ||
| config.resolve.fallback = { |
Contributor
There was a problem hiding this comment.
Is blanket approach unavoidable here? Can this be limited only to modules used by sass plugin?
Contributor
Author
There was a problem hiding this comment.
Yeah, that's actually a good catch. Made the webpack config scoped to the sass plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Issue
Next.js 16 upgrade broke Sass compilation in
nextjs-sxatemplate:sass-aliaspackage uses legacy Sass API incompatible with Next.js 16Fix
sass-aliaswith custom importer implementing Next.js 16 Sass APIsass-aliasdependencyTesting Details
Types of changes