Fix EffLook requiring a default entity to parse. #8315
+26
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested review from
Absolutionism and
Burbulinis
and removed request for
a team
sovdeeth
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
Efnilite
approved these changes
Dec 8, 2025
APickledWalrus
approved these changes
Dec 8, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.14 Releases
skriptlang-automation
bot
added
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Could not parse efflook in functions since the pattern has 2 required entity inputs, but only one is accessible/used at a time.
Solution
Separates the 2 into different patterns. Some cleanup to the class.
Testing Completed
Supporting Information
Completes: none
Related: none
AI assistance: none