Conversation
|
ci of c++11 is not supported. But I think maybe you can disable it first. And create an issue for that. We can see whether we can fix it or just abandon c++11 in our new version. |
|
I believe it is better to drop support for version before c++17 as long as dependencies like protobuf require c++17, see |
|
I am OK to that. We won't add too much new features to cpp2sky. So, I think it's fine to support only c++17 in our new version. who won't the old version support still could use our old version. |
|
I have removed '-Werror' so it doesn't fail on warnings. |
|
Following https://stackoverflow.com/a/39194946 recommendation |
|
@mmorel-35 sorry for the delay. There is no pr-reminder there Orz. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@wbpcode , |
|
CI still not happy. |
Description
Ubuntu-20.04 is not supported by github anymore.
actions/checkout@v3 is also not documented in the README
Also uses actions/checkouts instead of git clones, will reduce the space taken as the reference is precised with only one commit being checked out.
I also used stepsecurity to define permissions appropriately with commit sha
See