Skip to content

Feature: PR link#19

Open
ILike2WatchMemes wants to merge 19 commits into
SkyHanniStudios:masterfrom
ILike2WatchMemes:pr-link
Open

Feature: PR link#19
ILike2WatchMemes wants to merge 19 commits into
SkyHanniStudios:masterfrom
ILike2WatchMemes:pr-link

Conversation

@ILike2WatchMemes

@ILike2WatchMemes ILike2WatchMemes commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

Dependency

grafik

also adds the tag to the post

grafik

and forwards updates from the github webhook

grafik

@mariethepolarfox

Copy link
Copy Markdown
Contributor

Quick little suggestions (idk if implementable) using !pr without arguments in a linked channel runs pr with the channels linked pr number. Meaning if the channel for example is linked to #1234 and you run !pr without any arguments in that channel it runs !pr 1234 as that is the linked pr

@hannibal002

Copy link
Copy Markdown
Member

What other pr does this depend on?

@hannibal002 hannibal002 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are merge conflicts between this and master branch.
image

(idk why github doesnt show this)

@hannibal002 hannibal002 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good!
i have not yet tested this, as there are no file config options yet.
also please explain what webhook with what settings needs to be setup for this.

also can you add the support for !pr without args for checking if in a linked channel? as suggested above? should onky be just 1-2 more lines

Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/LinkListener.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/LinkListener.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/LinkListener.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/Database.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/Database.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/Database.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/Database.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/DiscordBot.kt Outdated
Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/DiscordBot.kt Outdated
@ILike2WatchMemes

Copy link
Copy Markdown
Contributor Author

also please explain what webhook with what settings needs to be setup for this.

you just need to set the id of the discord bot in the config (in the field "githubWebhookUserId") from the #github-updates channel for example

@hannibal002 hannibal002 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive removed some duplicate code, hope thats fine.

Comment thread src/main/kotlin/at/hannibal2/skyhanni/discord/DiscordBot.kt Outdated

@hannibal002 hannibal002 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also merge those code duplcations
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants