Fix note detail showing "/ 0 (-N remaining)" for unlimited views

[Osamaali313]

Problem

In the MyUploads TUI note-detail panel (apps/client/src/tui/views/MyUploads.tsx), the view counter renders unconditionally:

{liveNote.viewCount} / {liveNote.maxViews}
<Text dimColor> ({liveNote.maxViews - liveNote.viewCount} remaining)</Text>

But maxViews === 0 means unlimited, and it's the default (NOTE_DEFAULT_VIEWS = "0" in the server config; the server treats 0 as unlimited throughout). So a default note that's been viewed 3 times renders:

Views:     3 / 0 (-3 remaining)

— a nonsensical / 0 and a negative "remaining", implying the link is exhausted when it isn't.

Evidence (siblings prove intent)

Every other place that renders view counts special-cases 0:

• CLI list: n.maxViews === 0 ? \${n.viewCount} / ∞` : …`
• web NoteCard: info.maxViews === 0 ? …
• client note command: Views: ${maxViews === 0 ? "unlimited" : maxViews}

Only this TUI panel doesn't. (The adjacent uploads panel uses the same max - count pattern correctly, because maxDownloads is schema-validated positive and can never be 0.)

Fix

Mirror the siblings — show ∞ for unlimited and only show the "remaining" hint for a finite limit:

{liveNote.viewCount} / {liveNote.maxViews === 0 ? "∞" : liveNote.maxViews}
{liveNote.maxViews > 0 && (
  <Text dimColor> ({liveNote.maxViews - liveNote.viewCount} remaining)</Text>
)}

Reproduction

Default (unlimited) note viewed 3×:

	rendered
before	Views: 3 / 0 (-3 remaining) ❌
after	Views: 3 / ∞ ✅

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Skyfay]

Hey @Osamaali313

Thanks for your contribution.
I'll include that fix in the next version.

Thanks :)

[Osamaali313]

Thanks @Skyfay, glad it helps — happy to adjust anything if needed when you pull it into the next release. Appreciate the quick response!