[BpkFloatingNotification] [ISO-1654] Add critical floating notification type#4323
Draft
[BpkFloatingNotification] [ISO-1654] Add critical floating notification type#4323
Conversation
Co-authored-by: mariia-shyn <206853533+mariia-shyn@users.noreply.github.com> Agent-Logs-Url: https://github.com/Skyscanner/backpack/sessions/f174a053-ae89-4460-92e0-5ba588025df6
Copilot created this pull request from a session on behalf of
mariia-shyn
March 25, 2026 14:08
View session
|
Visit https://backpack.github.io/storybook-prs/4323 to see this build running in a browser. |
mariia-shyn
changed the title
…er-error-day Co-authored-by: mariia-shyn <206853533+mariia-shyn@users.noreply.github.com> Agent-Logs-Url: https://github.com/Skyscanner/backpack/sessions/8ecf1b22-dd87-4bbf-a8a5-6176ca2ba3d6
| } | ||
|
|
||
| &--critical { | ||
| background-color: tokens.$bpk-private-info-banner-error-day; |
There was a problem hiding this comment.
We should not use a component token from another component. When we do this it will make theming unpredictable.
There was a problem hiding this comment.
Copilot please use $bpk-status-danger-spot-day for the background color.
Contributor
Author
There was a problem hiding this comment.
Updated in b09f27b to use tokens.$bpk-status-danger-spot-day — a proper semantic status token rather than the cross-component private token.
Copilot started work on behalf of
Gert-Jan Vercauteren (gert-janvercauteren)
March 26, 2026 13:08
View session
Co-authored-by: gert-janvercauteren <728889+gert-janvercauteren@users.noreply.github.com> Agent-Logs-Url: https://github.com/Skyscanner/backpack/sessions/b87498a9-d2e1-4a93-bcb7-7fd55fb89daa
|
Visit https://backpack.github.io/storybook-prs/4323 to see this build running in a browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$bpk-critical-background-day: #e70866;local variable fromBpkFloatingNotification.module.scssbackground-color: $bpk-critical-background-daywithbackground-color: tokens.$bpk-status-danger-spot-dayin the&--criticalblock (uses a proper semantic status token rather than a cross-component private token, to avoid unpredictable theming)Remember to include the following changes:
[Clover-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.