first commit #1
Open
first commit #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naikonst
reviewed
Apr 27, 2020
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| </component> | ||
| </module> | ||
|
|
There was a problem hiding this comment.
Во время разработки возникает много разных файлов и папок, которые не относятся к коду и могут засорять репозиторий. Для того, чтобы не убирать их вручную каждый раз существует gitignore - это файл .gitignore, который кладется в папку с проектом и в нем описываются файлы, которые GIT должен игнорировать. Советую настроить его, чтобы такие технические файлы не попадали в GIT. Пример можно посмотреть здесь - https://github.com/Naikonst/Geekbrains-Java3
Naikonst
reviewed
Apr 27, 2020
| } | ||
| // сравнить | ||
| public boolean compare(Box <?> box){ | ||
| return (this.getWeight()-box.getWeight() < 0.0001); |
There was a problem hiding this comment.
Здесь надо использовать модуль - Math.abs, иначе 2 коробка будет больше, то разница будет отрицательной и вернется true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.