fix(omnibar): ensure omnibar overlaps app content [#425] #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themightychris
requested changes
Feb 8, 2023
Comment on lines
+10
to
+14
|
|
||
| div[id^='slate-cbl-'][id*='-picker'], | ||
| .x-css-shadow { | ||
| z-index: 10 !important; | ||
| } |
Contributor
There was a problem hiding this comment.
It's not a good idea to monkey-patch the generated ExtJS styling like this, and the selector is liable to not catch everything ExtJS might put above the omnibar
A better approach instead of this would be to find the existing place where .slate-omnibar is assigned a z-index: 99 and set that to z-index: 999999 as our intention is that the omnibar should cover EVERYTHING. That way we don't have to get into whack-a-moleing specific things to be lower than it
themightychris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowers the z-index for dropdown menus in the header so that the omnibar is on top