feat: improve developer experience with validation, health checks, and guidelines - #269
Merged
ritaifeoluwa merged 1 commit intoAug 28, 2026
Conversation
…d guidelines - Webhook event validation: Enhanced error messages with specific invalid events and all valid options - Price source health: Added last_success_at tracking to circuit breakers for API availability visibility - Swagger UI auth: Updated security scheme from HTTP bearer to apiKey for better UX in trying protected endpoints - Developer guide: Added comprehensive CONTRIBUTING.md with setup, testing, and PR guidelines Fixes SmartDropLabs#1 SmartDropLabs#2 SmartDropLabs#3 SmartDropLabs#4
|
@Just-Bamford Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four critical issues to improve code quality, developer experience, and operational visibility.
Closes #213
Closes #212
Closes #214
Closes #215
Changes
1. Webhook Event Type Validation
webhookSubscriptionSchemainsrc/validation/schemas.jswithsuperRefinefor detailed error reportingtest/webhooks.routes.test.jsnow validates error message content2. Price Source Health Tracking
last_success_attimestamp tracking to circuit breakers insrc/services/sources/circuitBreaker.jsclose()now records the timestamp/healthendpoint includeslast_success_atper source inprice_source_circuitstest/circuitBreaker.test.jsto validate timestamp tracking3. Swagger UI Authentication Support
openapi.yamlsecurity scheme from HTTP bearer toapiKeytypetype: http, scheme: bearertotype: apiKey, in: header, name: Authorizationtest/api-docs.test.js4. Comprehensive Developer Guide
CONTRIBUTING.mdwith complete development guidelines: