feat: add dead letter queue for failed webhook deliveries - #271
Open
Toyosi5566 wants to merge 8 commits into
Open
feat: add dead letter queue for failed webhook deliveries#271Toyosi5566 wants to merge 8 commits into
Toyosi5566 wants to merge 8 commits into
Conversation
|
@Toyosi5566 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a dead letter queue (DLQ) for webhook deliveries that exhaust their retry attempts. Instead of losing the event payload after a delivery is permanently failed, the full delivery context — including payload, error history, and attempt details — is persisted in a Redis sorted set. New DLQ API endpoints allow operators to list stuck deliveries and retry them, while a TTL automatically expires old entries.
Related Issue
Closes #
Changes
🗂️ DLQ Storage & Lifecycle
[ADD]
src/services/webhookDlq.js[MODIFY]
src/config.js[MODIFY]
src/services/cache.jszadd,zrange,zrem,expire) used by the DLQ.🔌 Webhook DLQ API
[MODIFY]
src/routes/webhooks.jsGET /webhooks/dlqto list DLQ entries ordered by when they failed.POST /webhooks/dlq/:id/retryto re-dispatch an existing DLQ entry.[MODIFY]
src/services/webhook.js🔁 Delivery & Retry Integration
[MODIFY]
src/services/webhookDispatcher.js[MODIFY]
src/repositories/deliveryRepository.js[MODIFY]
src/jobs/webhookRetryWorker.jsVerification Results
GET /webhooks/dlqreturns entriesPOST /webhooks/dlq/:id/retryre-dispatchesCloses #257