Unlock fee estimate, root loading state, global RPC-down banner (#240, #242, #248) - #259
Merged
ritaifeoluwa merged 3 commits intoAug 25, 2026
Conversation
…#240) UnlockModal submitted unlock transactions with no fee estimate — users only found out the cost once Freighter's signing prompt appeared. Added buildUnlockAssetsTransaction/simulateUnlockAssets (mirroring the existing lock-side pair) and useUnlockAssetsFeePreview (mirroring useLockAssetsFeePreview's debounced-simulation pattern), then wired the result into the modal's existing amount-preview box next to "Estimated receive"/"Remaining stake"/"New daily rate".
…pLabs#242) Color-mode FOUC was already prevented by the existing ColorModeScript + colorModeManager={localStorageManager} setup, and font-load FOUT by next/font's display:"swap" — both already correct. The one real gap was no Suspense fallback for the root segment: Next.js's app/loading.tsx convention shows this while the initial app boot (or a slow route transition) is in flight, instead of a blank screen.
…s#248) When the RPC endpoint is down, every page independently showed its own query error with no indication it's a shared, app-wide outage. Added useRpcHealth (a lightweight getHealth() poll, 30s interval) and a RpcUnreachableBanner mounted globally in AppShell, mirroring NetworkMismatchBanner's sticky-alert pattern — one unified signal instead of N independent, cryptic per-page errors.
|
@richardtoms100 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
❌ Deploy Preview for smart-drop failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Already resolved on inspection
Test plan
Closes #240
Closes #242
Closes #248
Closes #241