Skip to content

feat(subscriptions): add native share sheet to SubscriptionCard and SubscriptionDetail#509

Open
fantababa wants to merge 1 commit into
Smartdevs17:mainfrom
fantababa:feature/add-subscription-share
Open

feat(subscriptions): add native share sheet to SubscriptionCard and SubscriptionDetail#509
fantababa wants to merge 1 commit into
Smartdevs17:mainfrom
fantababa:feature/add-subscription-share

Conversation

@fantababa
Copy link
Copy Markdown

@fantababa fantababa commented Jun 1, 2026

Closes #74

feat(subscriptions): add native share sheet to SubscriptionCard and SubscriptionDetail

Add share functionality to subscription components using the native Share API from react-native.

  • SubscriptionCard: adds a Share button on the left of the actions row that triggers the native share sheet with subscription name, price, billing cycle, and a deep link placeholder
  • SubscriptionDetailScreen: adds a Share button in the header alongside the existing Edit button, using the same share payload
  • Both implementations wrap Share.share() in try/catch and silently ignore Share.dismissedAction to handle cancellation gracefully
  • No sensitive data (crypto keys, gas info, group membership) is included in the shared payload

Pull Request Checklist

Quality Gates (All must pass before merge)

  • Lint: Code passes ESLint and Prettier checks
  • Type Check: TypeScript compilation succeeds
  • Tests: All tests pass
  • Build: Project builds successfully
  • Rust Format: Smart contract formatting is correct
  • Rust Clippy: Smart contract linting passes
  • Rust Tests: All smart contract tests pass
  • Rust Build: Smart contracts compile successfully

Additional Requirements

  • New code has appropriate TypeScript types
  • No hardcoded secrets or credentials
  • New features have corresponding tests
  • Documentation updated if needed

Reviewers

  • At least 1 approval required for merge
  • All CI checks must be green

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 1, 2026

@fantababa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Smartdevs17
Copy link
Copy Markdown
Owner

merge conflicts

@Smartdevs17
Copy link
Copy Markdown
Owner

⚠️ Merge failed — check CI status.

🤖 Drips Wave Merge Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔧 Add share functionality for subscriptions

2 participants