Conversation
This essentially cherry picks an improvement from Rumur.¹ ¹ Smattr/rumur@dc1edfb
Smattr
force-pushed
the
smattr/github-285
branch
2 times, most recently
from
September 10, 2026 01:22
0f41019 to
efc306b
Compare
GCC+Glibc on Ubuntu 26.04 seems to apply C23 rules to this code and
propagate the const-ness of the input across `strrchr`:
libclink/src/db_open.c: In function ‘clink_db_open’:
libclink/src/db_open.c:261:19: error: initialization discards ‘const’
qualifier from pointer target type [-Werror=discarded-qualifiers]
261 | char *slash = strrchr(path, '/');
| ^~~~~~~
Reported-by: GCC 15.2.0 -Wdiscarded-qualifiers
At this point, Cirrus CI is well and truly dead. Its domain is unreachable.
Smattr
force-pushed
the
smattr/github-285
branch
from
September 10, 2026 01:31
efc306b to
fab6ee6
Compare
Cirrus CI is dead.
Cirrus CI is dead.
In preparation for this file containing non-Vim related things. Github: #285 “When opening a file with the editor Jump to the line of code”
Github: #285 “When opening a file with the editor Jump to the line of code”
Github: #285 “When opening a file with the editor Jump to the line of code”
Github: #285 “When opening a file with the editor Jump to the line of code” Reported-by: Github user dtscbs
Smattr
force-pushed
the
smattr/github-285
branch
from
September 10, 2026 01:43
fab6ee6 to
b55bb9c
Compare
Smattr
added a commit
that referenced
this pull request
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.