CI: CMake linting - #350
Merged
Merged
Conversation
Generic named targets like this do not compose well with outer build systems.
While addressing the issues the linter complains about, this also adds `murphi2smv` to the test dependencies. It seems we have no tests of this but for consistency it seems wise to make it available to the tester. Note that this required breaking up the `$PATH` manipulation for the test target. CMake appears to have no way to continue non-string text across multiple lines. The result is probably a net improvement anyway though.
This should have gone into 5b04874.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.