feat: oidc auto redirect on login page - #649
Merged
Merged
Conversation
Contributor
Author
|
Thanks! I noticed the problems with linter, sorry for not catching it earlier, I can fix it later today if you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #626
I added two env variables:
CONFIG_HIDE_NATIVE_LOGIN: Hides native username/password login if set to true (useful if you only want OAuth providers)CONFIG_OIDC_PROVIDER_AUTO_REDIRECT: Name of OIDC provider to redirect to when landing on login page (can be omitted)I feel like
CONFIG_HIDE_NATIVE_LOGINmight be a bit redundant withCONFIG_DISABLE_NATIVE_LOGINbut at the end they serve slightly different purposes. I think they might joined inCONFIG_DISABLE_NATIVE_LOGINunless someone has a use case for an only disabled form.I hope I used Nuxt config/env the correct way and also hope I updated all the docs.
Let me know if any changes are needed :)