Harden auth recovery, abuse controls, and runtime - #38
Merged
Conversation
capybaracplusplus
marked this pull request as ready for review
July 31, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous implementation had environment ambiguity between host and container builds, root-only functional tests, and race windows around rate limits, one-time credentials, and outbox job reclamation. This change makes those state transitions transactional, gives the service explicit operational health contracts, and establishes a reproducible portfolio-quality build and test baseline.
Validation
cmake --build build-debug --target smirkly-auth smirkly-auth_unittest --parallel 1ctest --test-dir build-debug --output-on-failure(unit suite and 29 functional scenarios)cmake --preset releasecmake --build build-release --target smirkly-auth --parallel 2up -> down -> upcycle200with schema version11; health endpoints returned404on the public listenerstatic_config.prod.yamlclang-format --dry-run --Werror; YAML and local OpenAPI references validateOperational notes
Email delivery remains intentionally at-least-once: an SMTP success followed by a database failure may produce a duplicate delivery. Sign-up abuse protection still requires an edge/gateway limiter until a shared application-level sign-up limiter is added.