feat(auth): harden registration security defaults - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Registration was the remaining public authentication flow without a shared-store application limiter. Concurrent requests could therefore bypass any process-local control and trigger expensive password hashing. The previous verified-email default was also permissive, and terminal outbox rows retained verification or recovery material indefinitely.
The limiter now validates cheap input first, then atomically consumes a PostgreSQL slot before uniqueness queries and bcrypt. It stores only normalized IP and timestamp; edge limits remain required for malformed bodies and traffic bursts.
Behavior changes
max_attempts_per_ipreturn429 auth.sign_up.too_many_attemptssign_in.require_verified_emaildefaults totrue, but remains dynamically configurableemail_outboxrows retain delivery metadata while replacingpayloadwith{}0012createssign_up_attemptsValidation
testsuite,tests-control, and public ping disabled)clang-format --dry-run --Werrorgit diff --checkpassThe local ARM devcontainer cannot finish the static Debug ASan/UBSan link within its 8 GB memory limit (
ldis killed by the kernel). All Debug objects compile; the canonical Debug sanitizer job remains enabled in GitHub Actions.