fix(packaging): give the app its own icon instead of Electron's default - #8
Merged
Merged
Conversation
The Windows build never had its .exe edited (`signAndEditExecutable: false`, set because the winCodeSign bundle can't be extracted without symlink rights on a normal Windows account), and that edit is what stamps the app icon and version info into the executable. Installed builds therefore showed Electron's default icon and called themselves "Electron" by "GitHub, Inc.". - Release and CI packaging now pass -c.win.signAndEditExecutable=true; their runners have the privilege. Local builds keep it off so `npm run package` still works without Developer Mode. - The window gets the icon explicitly on Linux, where a window has none of its own, and in `npm run dev:electron`, which runs the plain electron binary. Verified locally with the edit enabled: the .exe carries the app icon and reports ProductName "BetterSshClient". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Windows runners default to PowerShell, which splits `-c.win.signAndEditExecutable=true` at the dot into `-c` and `.win.signAndEditExecutable=true`; electron-builder then tried to load the latter as a config file and the Windows package job failed. The release workflow had the same line and would have failed on the next release. Reproduced with node's argv under PowerShell; bash passes it intact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows build never had its .exe edited (
signAndEditExecutable: false, set because the winCodeSign bundle can't be extracted without symlink rights on a normal Windows account), and that edit is what stamps the app icon and version info into the executable. Installed builds therefore showed Electron's default icon and called themselves "Electron" by "GitHub, Inc.".npm run packagestill works without Developer Mode.npm run dev:electron, which runs the plain electron binary.Verified locally with the edit enabled: the .exe carries the app icon and reports ProductName "BetterSshClient".
What and why
How it was tested
Checklist
npm run checkandnpm testpass