Improve error union demo code #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in the current error union demo code, named `maybe_error` would never actually error. This change improves on the demonstration of how `catch` works by actually using it.
When we run our test we're comparing at runtime but need to compare at comptime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code in the current error union demo code, named
maybe_errorwould never actually error. This change improves on the demonstration of howcatchworks by actually using it.Changes
Sets the
maybe_errorto be of valueAllocationError.OutOfMemorywhich means the value ofno_errorwould use thecatch, displaying the way that catch is used in Zig with an error union.