feat(workspace-mail): external SMTP + IMAPS LoadBalancers on the reserved IPs - #1140
Merged
Conversation
…rved IPs Makes the mail plane externally reachable (it was ClusterIP-only). Two L4 LB Services bound to the reserved static IPs (ws-smtp 130.211.115.191, ws-imap 136.116.203.17), separate from the ClusterIP services so 143/lmtp stay internal-only and just the secure external ports (25/587, 993) are exposed. externalTrafficPolicy: Local preserves the real client source IP — mandatory for SMTP reputation/RBL/SPF. Safe to land: MX stays on Google until TLS + mail-tester>=9/10, so nothing real lands here yet.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds external-facing L4 LoadBalancer Services for the workspace mail plane, binding them to reserved static IPs so SMTP and IMAPS can be reached from the internet.
Changes:
- Introduce
workspace-smtp-lb(ports 25/587) andworkspace-imap-lb(port 993)Serviceresources withexternalTrafficPolicy: Local. - Register the new Service manifest in the base kustomization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infra/k8s/workspace-mail/base/service-lb.yaml | Adds two external LoadBalancer Services pinned to reserved IPs for SMTP + IMAPS. |
| infra/k8s/workspace-mail/base/kustomization.yaml | Includes the new LB Service manifest in rendered resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+11
| # SEQUENCING: safe to land now — the MX stays on Google until TLS is verified (mail-tester >= 9/10), | ||
| # so no real inbound traffic lands here yet. Do NOT cut the MX over until Dovecot ssl=required + a | ||
| # cert-manager cert are in place, or 993 would be plaintext. |
Comment on lines
+16
to
+17
| annotations: | ||
| networking.gke.io/load-balancer-type: "External" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the sovereign mail plane externally reachable — it's been ClusterIP-only (internal skeleton). Companion to the tofu IPs/cert-manager PR (#1139).
What
Two L4
LoadBalancerServices ininfra/k8s/workspace-mail/base, bound to the reserved regional static IPs:workspace-smtp-lb→130.211.115.191(ws-smtp): 25 (inbound MX) + 587 (submission)workspace-imap-lb→136.116.203.17(ws-imap): 993 (IMAPS)Kept separate from the existing ClusterIP services so 143 (plaintext IMAP) + 24 (lmtp) stay internal-only — only secure/needed ports face the internet.
externalTrafficPolicy: Local— preserves the real client source IP, which SMTP reputation, RBL/greylisting, and SPF all depend on (SNAT would hide it).Sequencing (safe to merge now)
The MX stays on Google until TLS is verified (mail-tester ≥ 9/10), so no real inbound traffic hits these yet. Do not cut the MX over until Dovecot
ssl=required+ a cert-manager cert are in place, or 993 is plaintext.Verified
kubectl kustomize overlays/p0-labrenders both LB Services with the correct IPs/ports.Unblocks
Once merged + synced, the LBs get forwarding rules → then PTR on ws-smtp and TLS issuance (ACME DNS-01 via the new
acme.socioprophet.aiCloud DNS delegation zone) can proceed.🤖 Generated with Claude Code