fix(identity-firmographic): crypto.randomUUID ids; distinguish absent vs empty-string fields

[mdheller]

Summary

Two small correctness fixes in services/identity-firmographic-alpha-runtime/server.js:

1. Replace Date.now() + Math.random().slice(2,10) id generation with crypto.randomUUID().
2. Fix the truthy-check on doc.company_name / doc.person_name so that a payload with an empty-string field is not silently classified as absent.

1. Id-collision surface

Before:

function id() {
  return \`rec_\${Date.now()}_\${Math.random().toString(36).slice(2, 10)}\`;
}

Under concurrent ingest at the same millisecond, the only entropy separating two ids is the 8-hex-char random suffix, i.e. ~2^42 (~4.3B) distinct values. Birthday-collision territory ($\sim\sqrt{2^{42}} \approx 2M$) sits well within the requests-per-day this runtime is expected to see, so rec_* values used downstream as record keys can collide. This is a recurring defect class — non-cryptographic PRNG + timestamp for what is functionally a key.

After:

const crypto = require('node:crypto');
function id() {
  return \`rec_\${crypto.randomUUID()}\`;
}

crypto.randomUUID() is a v4 UUID from a CSPRNG — 122 bits of entropy, collision probability negligible at any realistic ingest rate.

2. Empty-string vs absent

Before:

if (!doc.company_name && !doc.person_name) { /* 400 missing */ }
...
if (doc.company_name) envelopes.push(buildOrgEnvelope(...));
if (doc.person_name) envelopes.push(buildPersonEnvelope(...));

An empty string is falsy in JS, so a caller who intentionally sent {"company_name": ""} got back the 400 missing company_name and person_name — even though the field was provided (just empty). Envelope construction had the same defect: an empty-string company_name silently produced no organization envelope, so the response's envelope_count disagreed with what the caller thought they sent.

After: presence is checked with Object.prototype.hasOwnProperty.call(doc, 'company_name'), and a present-but-empty value gets its own distinct 400:

if (hasCompany && doc.company_name === '') {
  return sendJson(res, 400, { error: 'company_name provided but empty', request_id: requestId });
}

Envelopes now key off presence, not truthiness, matching the surface's contract that these fields are the shape identifiers for organization / person.

This is the same "empty-string treated as absent" pattern I've been finding in other services across the estate. Worth flagging at review time because it's a defect class rather than a one-off — anywhere a JS handler uses if (!x) on an optional user-supplied string, the same audit applies.

Test plan

• node --check services/identity-firmographic-alpha-runtime/server.js passes.
• Existing tests in services/identity-firmographic-alpha-runtime/ still pass; any tests that assert the exact 400 body for missing fields still match (unchanged for the truly-absent case).
• POST /ingest/identity-firmographic with {"company_name": ""} returns 400 company_name provided but empty (was: 400 missing company_name and person_name).
• POST /ingest/identity-firmographic with {} returns 400 missing company_name and person_name (unchanged).
• POST /ingest/identity-firmographic with {"company_name": "Acme"} still produces a 202 with the organization envelope (unchanged behavior on the happy path).
• Two ingest calls in the same millisecond produce distinct request_id values.

[Copilot]

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

This PR improves correctness in the identity-firmographic ingest runtime by strengthening request ID generation and by distinguishing between absent vs present-but-empty company_name / person_name fields during validation and envelope creation.

Changes:

• Switches request/record ID generation to use crypto.randomUUID() instead of timestamp + Math.random().
• Reworks validation/envelope routing to use field presence (hasOwnProperty) rather than truthiness.
• Adds explicit 400 errors for present-but-empty string values for company_name / person_name.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.