Skip to content

Validate production config secrets#10

Closed
h1065153539-create wants to merge 2 commits into
Soengkit:mainfrom
h1065153539-create:codex/config-production-secret-validation-20260620211452
Closed

Validate production config secrets#10
h1065153539-create wants to merge 2 commits into
Soengkit:mainfrom
h1065153539-create:codex/config-production-secret-validation-20260620211452

Conversation

@h1065153539-create

Copy link
Copy Markdown

Summary

  • Adds production-only validation for required secrets in tools/config_generator.py.
  • Rejects empty or placeholder-like database.password, redis.password, and auth.jwt_secret values without printing secret values.
  • Adds --override-json so production callers and tests can provide real secret values before output is accepted.
  • Adds missing, placeholder, and valid secret fixtures plus unittest coverage, and documents the production behavior in operations notes.

Validation

  • python3 -m py_compile tools/config_generator.py tools/test_config_generator_secrets.py passed.
  • python3 -m unittest tools/test_config_generator_secrets.py -v passed.
  • CLI smoke confirmed default production config exits non-zero, placeholder values exit non-zero without leaking values, and valid overrides produce masked output.
  • Diagnostic artifacts included: diagnostic/build-4981a8ee.logd and diagnostic/build-4981a8ee.json.

Security

  • Error output lists only key names, not values.
  • Non-production config generation remains compatible.
  • Default masked output remains the default even for valid production overrides.

Closes #1

@Soengkit

Copy link
Copy Markdown
Owner

Closing this PR because the linked fork issue is only a closed payout tracker for an already submitted upstream PR. This fork is not an active bounty intake or payment authority, and it is not accepting external submissions or payment details here.

@Soengkit Soengkit closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payout tracking for upstream PR #442

2 participants