fix(clone): create missing destination folder on clone - #265
Open
sidimed-bahan wants to merge 1 commit into
Open
fix(clone): create missing destination folder on clone#265sidimed-bahan wants to merge 1 commit into
sidimed-bahan wants to merge 1 commit into
Conversation
…oring clone_repo now create_dir_all's the destination parent when it's absent, and clone_github_repo_and_add tilde-expands the typed path first so `~/Desktop/...` resolves to an absolute path before cloning. The destination autocomplete drops its inline "Create <name>" row and the "folder doesn't exist" warning (new allowCreate prop on PathAutocomplete, defaults to true so BtsBuilder keeps inline create) — the path is created under the hood when you click Clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Clone GitHub repo dialog, typing a destination folder that doesn't exist yet (e.g.
~/Desktop/SoftwareSavants/code) failed the clone withDestination parent does not exist. The destination autocomplete also nagged with an inlineCreate "<name>"row and a "folder doesn't exist" warning.Changes
github.rs—clone_reponowcreate_dir_alls the destination parent when it's missing, instead of erroring.ipc.rs—clone_github_repo_and_addtilde-expands the typed path (expand_tilde) before cloning, so~/...resolves to an absolute path (matchinglist_subdirs/create_subdir). Required — otherwisecreate_dir_allwould create a literal~folder.PathAutocomplete.tsx— newallowCreateprop (defaultstrue). The clone dialog passesallowCreate={false}to suppress the inline Create row and its warning; the path is created under the hood on Clone.BtsBuilderDialogkeeps its inline create.Tests
clone_creates_missing_destination_parent(Rust) — asserts the missing parent gets created.does not show the Create row when allowCreate is false(frontend).Net effect: type any destination path, click Clone, and it's created under the hood.