Fix publish workflow: restore build tasks on push to dev, remove duplicate quarantine#52
Merged
Merged
Conversation
- Rename workflow from 'publish' to 'Publish' for proper UI display - Fix run-name to show meaningful text for all trigger types - Add push trigger for dev branch (was workflow_dispatch + release only) - Remove inputs.bump/version gate from version, build-cli, build-tauri jobs so builds actually run on push to dev (was: only on workflow_dispatch with bump) - Add release trigger to build-tauri (was missing entirely) - Add github.sha to concurrency key to prevent push events cancelling each other - Remove duplicate .github/workflows/quarantine/ files that were re-introduced by merge from origin/dev after the rename to github/quarantine/
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
publish.yml
publishtoPublishfor proper UI displayrun-nameto show meaningful text for push, release, and workflow_dispatchpushtrigger fordevbranch (was workflow_dispatch + release only)inputs.bump || inputs.versiongate from version, build-cli, build-tauri jobs so builds run on every push to devgithub.event_name == 'release'to build-tauri (it was missing the release trigger entirely)github.shato concurrency key to prevent sequential push events from cancelling each otherQuarantine cleanup
.github/workflows/quarantine/files re-introduced by merge from origin/dev after the rename togithub/quarantine/Testing
All typechecks pass (12/12). Build jobs will run on push to dev once merged.