ci: reusable build workflow + per-merge CI + CodeQL#54
Merged
Conversation
publish.yml had build-cli and build-tauri as the only build pipeline, gated to release/dispatch on the integration branch. Pull them into _build.yml as a reusable workflow so the same definition drives both release publishes and per-merge verification. - _build.yml: reusable workflow taking version/release/tag inputs. Empty release+tag -> tauri-action produces workflow artifacts only; set -> attaches to the GitHub release draft. - ci.yml: post-merge verification on push to main/dev. No pull_request trigger, so fork secrets never leak and Actions minutes are not spent on every WIP push. workflow_dispatch for ad-hoc re-runs. - codeql.yml: committed CodeQL workflow replacing default setup. Scans javascript-typescript and actions (catches secret-handling/injection bugs in workflow files; cf. 5569e76). - publish.yml: build-cli/build-tauri replaced by a workflow_call to _build.yml. Tightens the release-trigger output step (SC2129). Before merging: disable Code scanning default setup in repo settings, otherwise codeql.yml will conflict.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Document the three build paths (local desktop, local CLI, CI verification, release publish), the reusable-workflow architecture, the 5-target matrix, and the signing/notarization secret chain. Cross-reference APPLE.md for the macOS notarization deep dive. - BUILDING.md: new doc covering the full pipeline. - CONTRIBUTING.md: pointer from the existing "Developing" section to BUILDING.md for the deeper story. - README.md: build status badge now points at ci.yml on main (the workflow that actually fires on push), not publish.yml on dev (which is dispatch-only and never updates).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-cli+build-taurifrompublish.ymlinto_build.ymlas a reusable workflow callable viaworkflow_call.ci.yml: per-merge verification on push tomain/dev. Nopull_requesttrigger, so fork code never sees secrets and Actions minutes are not burned on every WIP push.codeql.yml: committed CodeQL workflow (replaces default setup). Scansjavascript-typescriptandactions(catches secret-handling and injection bugs in workflow files; cf. 5569e76).publish.ymlto delegate build jobs to_build.ymlviaworkflow_call, keeping theversionandpublishjobs in place.BUILDING.mdcovering all build paths (local desktop, local CLI, CI verification, release publish), the reusable-workflow architecture, the 5-target matrix, and the signing/notarization secret chain. CONTRIBUTING.md gets a pointer to it.README.mdbuild-status badge: now points atci.ymlonmain(the workflow that actually fires) instead ofpublish.ymlondev(dispatch-only, never updates).When
_build.ymlis called with emptyreleaseandtaginputs,tauri-actionproduces workflow artifacts only with no release attachment. When called with both set (frompublish.yml), it attaches to the GitHub release draft. One canonical build definition, two callers.Cost
Full 5-target matrix (macOS x64/arm64, Windows x64, Linux x64/arm64) on every merge to
main/dev. Estimate ~300-500 billable minutes per merge (macOS at 10x multiplier). Frequency bounded by merge rate, not push rate.Swatinem/rust-cachealready wired in.Before merging
codeql.ymlconflicts.Test plan
typecheck+testshould run on this PR).main,ciworkflow fires and the 5-target Tauri matrix completes.actionlint .github/workflows/*.ymlexits clean (verified locally).gh workflow run publish.ymlstill works end-to-end (manual smoke test after merge).ci.ymlrun onmain.