Add Rust CodeQL coverage with buildless extraction#56
Merged
Conversation
Default code-scanning setup covered actions/js-ts/rust while the advanced codeql.yml only covered js-ts and actions. To retire default setup without losing Rust analysis of the Tauri surface (packages/desktop/src-tauri), add a rust matrix entry. build-mode none uses CodeQL's buildless extractor, so no cargo build or system libraries are needed in CI. Switch the matrix to include form so build-mode can be set per language.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the duplicate CodeQL configuration (repo default-setup + advanced
codeql.ymlwere both active and conflicting).rustentry to the analyze matrix so the advanced config matches default setup's language coverage (packages/desktop/src-tauri). Default setup scanned actions/js-ts/rust;codeql.ymlonly scanned js-ts + actions, so disabling default setup would have silently dropped Rust analysis.build-mode: none(CodeQL buildless extraction) for Rust — no cargo build or system libs (libwebkit2gtk etc.) needed in CI.includeform sobuild-modecan be set per language.After this merges, repo default code-scanning setup will be disabled so only this advanced workflow runs (no more duplicate scans / rejected SARIF uploads).
Test plan
Analyze (javascript-typescript),Analyze (actions), andAnalyze (rust)— all green.codeql.ymlscans appear in the Actions tab / code-scanning alerts.