Skip to content

Restore corrected EmberHarmony asset variants#60

Merged
sydneyrenee merged 3 commits into
devfrom
solaceproject/fix-emberharmony-assets
May 31, 2026
Merged

Restore corrected EmberHarmony asset variants#60
sydneyrenee merged 3 commits into
devfrom
solaceproject/fix-emberharmony-assets

Conversation

@sydneyrenee
Copy link
Copy Markdown
Member

Summary

  • restore the main-branch identity PNG for packages/identity/mark-512x512.png
  • restore the transparent-block mark-light.svg from main
  • restore docs favicon.svg and favicon-v3.svg to the original 24x24 transparent SVG contract

Verification

  • git diff --check
  • xmllint --noout packages/identity/mark-light.svg packages/docs/favicon.svg packages/docs/favicon-v3.svg
  • compared restored files byte-for-byte against origin/main

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies several SVG assets, including favicons and identity marks, by replacing complex paths with grid-like rect elements. However, the reviewer correctly identified that all the newly added rect elements contain empty fill="" attributes. Since empty fill attributes are invalid in SVG, they can cause rendering failures or default to black. The reviewer suggested replacing these with valid color values, such as currentColor or specific hex codes, to ensure proper rendering.

Comment thread packages/docs/favicon-v3.svg Outdated
Comment thread packages/docs/favicon.svg Outdated
Comment thread packages/identity/mark-light.svg Outdated
@sydneyrenee sydneyrenee merged commit 376349b into dev May 31, 2026
8 checks passed
@sydneyrenee sydneyrenee deleted the solaceproject/fix-emberharmony-assets branch May 31, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant