Restore corrected EmberHarmony asset variants#60
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies several SVG assets, including favicons and identity marks, by replacing complex paths with grid-like rect elements. However, the reviewer correctly identified that all the newly added rect elements contain empty fill="" attributes. Since empty fill attributes are invalid in SVG, they can cause rendering failures or default to black. The reviewer suggested replacing these with valid color values, such as currentColor or specific hex codes, to ensure proper rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification