Skip to content

Remove unnecessary hexlify from deser #33

Description

@sleepdefic1t

It is unnecessary to hexlify then unhexlify as shown below.

recipientId = hexlify(self.serialized)[
    recipient_start_index : recipient_start_index + 42
]
recipientId = b58encode_check(unhexlify(recipientId)).decode()

The code currently resides HERE (in multi_payment.py), but will change after the merger of #32 (to transfer.py).

(This change was not requested in #32 because it was introduced from upstream.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions