Stop Discord RPC during app shutdown - #79
Open
AJMC-DEV wants to merge 1 commit into
Open
Conversation
RetipApp starts Discord RPC during setup but did not stop it from OnShutdown, leaving the worker alive until process teardown. Stop it before the existing wallpaper cleanup so Discord finishes before the rest of the app shuts down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TiP starts Discord RPC during setup but did not stop it in
OnShutdown(). That left the worker running until process teardown.This adds an explicit
Stop()call before the existing wallpaper cleanup. It goes with SolarRecomps/rexglue-ostentation#2, which cleans up the runtime-side shutdown path.I rebuilt the generated code from the current
devbranch and completed a full RelWithDebInfo build. That branch does not currently register any CTest tests.