fix(emit): terminal is written once — refuse overwrite without force, atomic writes (F4) - #28
Merged
Merged
Conversation
terminate() silently overwrote an existing terminal_state.json, so a second call could replace an honest Succeeded/FailedBlocked record. It now refuses when the terminal file exists unless force=True (the documented deliberate-overwrite escape hatch), naming the written-once contract in the error. Whole-file writes for state.json and terminal_state.json now go through a temp file in the same directory then os.replace, so a crash mid-write can never leave truncated JSON, and the temp file is removed on failure (no *.tmp litter). Appends (RUNLOG, receipts) stay appends. README documents the enforcement at the terminal_state.json line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes external-review finding F4:
emit.terminatesilently overwroteterminal_state.json, and nothing inemit.pywrote atomically — README's "written once" claim was unenforced.terminate()now raisesEmitErrorwhen the terminal file already exists; the deliberate escape hatch is the new keyword-onlyforce=True.state.json,terminal_state.json) go through a same-directory temp file +os.replace, so a crash mid-write can never leave truncated JSON. Appends (RUNLOG, receipts) remain appends.terminal_state.jsonline now states the enforcement instead of asserting it.Test plan
force=Trueoverwrites and revalidates; no temp-file litter after success, refusal, or validation-failure paths🤖 Generated with Claude Code