fix(scaffold): metrics-clean RUNLOG seed — retire both recipes' inline resets - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
Root fix, metrics-clean by construction:
templates/RUNLOG.md.tmplno longer seeds a parseable placeholder iteration. The seeded RUNLOG now carries an## Entry format (reference — not an iteration, not scored)section that keeps the full instructional value (iteration format + complete outcome vocabulary for humans) while emitting zero## Iterationblocks —metrics._runlog_blocksonly scans^## Iterationheadings, so a fresh scaffold scores clean with no fabricated state.emit.open_contract(ws)with no args) now prints[];iterations_claiming_success == 0.seed_runlog=Falsekwarg was added — clean-by-construction makes it dead weight (open_contract(target)signature unchanged; YAGNI, per the option the issue offers).examples/langgraph-emit/graph_example.py,examples/temporal-certify/workflow_example.py) and their explanatory comments; recipe docs/README prose updated where it referenced the reset.scripts/test_template_roundtrip.pydrops the 14 now-unused RUNLOG fill keys — its strictest guard (test_every_template_fills_with_no_placeholder_remaining) can only catch more unfilled placeholders after key removal, never fewer.New regression test in
scripts/test_emit.py(test_open_contract_is_metrics_clean): assertsprovenance.unrecognized_outcomes == []anditerations_claiming_success == 0on a fresh scaffold.Verification (independent adversarial pass):
mainarchive fails withAssertionError: assert ['replace'] == [].langgraph+temporalio): 399 passed / 11 skipped / 0 failed on the branch vs 398/11 on cleanmainin the identical env — delta is exactly the new test, zero regressions. The recipe ST3 tests assertunrecognized_outcomes == []on the un-reset scaffold and pass.test_open_contract_is_doctor_clean);self_eval13/13;validate_frontmatter9/0.