Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(kernel): loop-engineer/event@1 EventStore + SQLite/WAL + deterministic reducer (#50) #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(kernel): loop-engineer/event@1 EventStore + SQLite/WAL + deterministic reducer (#50) #62
Changes from all commits
c1e7bf8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a CAS append succeeds but the caller times out and retries the same
event_idwith the sameexpected_sequence, this check runs before theUNIQUE(event_id)insert and raisesSequenceConflictErrorbecause the next sequence has already advanced. That makes the advertised duplicate-event retry path unavailable for the normal CAS retry scenario, so clients cannot distinguish a successfully persisted retry from a real sequence race; check for an existingevent_idbefore treating the stale expected sequence as a conflict, or return the existing event idempotently.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.