Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(cli): read-only loop status + loop replay runtime verbs (Refs #55) #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(cli): read-only loop status + loop replay runtime verbs (Refs #55) #70
Changes from all commits
a7b3289File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a store is tampered or raw-inserted with a single
run_id = '', discovery accepts it because it only checks the type; the CLI then reports anillegal_event_sequenceproblem and exits like a replay failure rather than treating the store as un-attemptable/corrupt. Since event@1 requires a non-emptyrun_id, this guard should reject empty strings before returning the discovered run id.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
terminal_state.jsonexists but is invalid JSON (or unreadable) and the event log has no terminal event, thisexceptcollapses the file toNone; the next branch then sees both sides as absent andreplayreturnsok: truewith no findings. That misses the file-without-event half of the terminal desync window for exactly the corrupt terminal-file case, so the parse/read failure should produce a finding or preserve a separate “file present” marker instead of treating it as absent.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.