docs(plan): commit the executed verifier-identity-independence plan (Slice 2) - #99
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af9a8100ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "visible_criteria": {"type": ["array", "null"], "items": {"type": "string"}, "default": null, | ||
| "description": "Criterion refs the verifier may see (repo-os-contract §17)."}, | ||
| "holdout_criteria": {"type": ["array", "null"], "items": {"type": "string"}, "default": null, | ||
| "description": "Criterion refs held back from the verifier (repo-os-contract §17)."} |
There was a problem hiding this comment.
This step constrains visible_criteria and holdout_criteria only in JSON Schema, despite the plan's validation-mode-parity requirement and its explicit claim that these fields receive a fallback type check. In an installation without jsonschema, _validate_tasks accepts values such as "holdout_criteria": "C-9"; criterion_partition then silently treats the malformed value as no holdout, while strict mode rejects the same contract. Add equivalent checks to the structural validator and malformed-value tests in both modes so the independence partition cannot depend on installed extras.
Useful? React with 👍 / 👎.
The 3-lens-reviewed plan PR #94 was executed against, committed post-execution per the Slice 1 precedent (#84). Includes the review-status header, post-review design changes, and the recorded deviations sections.