Fast-forward main#44
Merged
Megadash452 merged 133 commits intomainfrom Apr 22, 2026
Merged
Conversation
* One uses a query to load pages, so it takes a queryState and the getPage callback has a CharSequence parameter. * The other does not use a query, so it only takes a getPage callback that does not have a query parameter.
…er is not behaving as intended.
Updated CONTRIBUTING.md wot include the use of Github tags/labels.
* Tests passing, except for `pageByPageTest` because the android Pager wants to reload already loaded pages every time `scrollTo()` is called.
* `load()` did not return empty page if `loadSize` was < 0, did not run on worker thread, and did not ignore extra items when using `NoQuery` type. * `runWork()` did not set worker thread ID in execute.
…nted android tests (#14) * setup: local Android UI tests + GitHub CI for unit tests and instrumented android tests * fix: CI script bug on line 18 and made sure to use java@v4 + JDK 17 * fix: fix CI * fix: fix CI * fix: fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI * fix CI
* `runWork()` now catches its **task**'s Exceptions and returns a `Result`.
* Using `TestPager` instead of normal `Pager`. * Previously, in `pageByPageTest`, each successive page load reloaded previous pages, but this doesn't happen with `TestPager`. * Instead of expecting a *1-dimensional* list of items (`Int`), tests now expect a *2-dimensional* list (pages of items). This is because we can get the currently loaded pages from `TestPager`. * `genList()` now takes a `maxItem` argument instead of `numPages` to allow returning incomplete pages.
…`. This helps avoid verbosity.
> Note: Going forward, all Composables that are UI components in the app must go in the `ui` module.
* Moved `PlainToolTipBox` and `PlainSearchBar` from `/Utils.kt` to `/ui/utils/Common.kt`
* Also added doc comments for those items.
* Moved `NewTransactionForm` to the `ui` module.
* Moved the code for the **paged** items in the `LocationPickerDialog` out of `NewTransactionForm.kt` and into `/ui/utils/List.kt`.
* Split the `LazyColumn` into 2 components: `ListColumn` and `PagedListColumn`. The former is a light wrapper around `LazyColumn` but with a customized style, and the latter is a `ListColumn` for use with a `Pager`.
* The `PagedListColumn` is generic, so the old code can now be used with any `Pager`.
* It also has a `PagerController` that allows constructing the pager within the function call while being able to call `refresh()` form anywhere.
…ewTransactionForm` to its own file.
… be PagerGetter that handles an empty query.
… an Error ListItem.
…ngContent and errorContent. This is useful to assign test tags to these items.
…rmatting on currency
* Gradle can run pre-build rust script automatically on build (wish it was on sync, but I'll take it). * Added new border style (dashed). * Added all user icons (about 170 of them). * Icon picker dialog and color picker button + dialog are done.
* Added `UserIcons` object to access the *usericon_\** drawables. * The backing field is safely initialized using a Mutex, and the code runs in the WORKER_THREAD so that the UI thread is not blocked. * `rememberWork()` can take a **`key`** argument to rerun the work if the **`key`** changes.
* When user long-presses on a TagFrame, a DropdownMenu pops up with **Edit** and **Delete** actions. * Added edit and delete icons for those menu items. * Changed `TagCreatorDialog` to `TagEditorDialog`. * Tag operations is now only handled by the ViewModel. * `selectedTags` should only contain tag ID info. * Fixed UserIcons not loading in previews or tests; They should be loaded by the composables that use it instead. * Fixed miscellaneous visual effects.
…mplementation. All tests passing now :D
…lated UI elements to a new file.
…query. Also, NewLocationDialog can show the NearbyLocationsDialog with Addresses (not implemented).
…control what is shown at any stage of picking a location.
ALL TESTS PASSING!!! :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.