Skip to content

fix(BalanceList): prevent duplicate React keys and add tests for loading skeleton and empty state (#601) #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stayzappy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(BalanceList): prevent duplicate React keys and add tests for loading skeleton and empty state (#601) #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/components/BalanceList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,4 +377,41 @@ describe("BalanceList", () => {
expect(badgeOrder()).toEqual(["USDC", "USDT"]);
});
});

describe("duplicate key prevention (#601)", () => {
it("renders without console duplicate key warnings when multiple balances share identical asset fields", () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});

const duplicateAsset1 = {
asset: "DUPLICATE_ASSET",
balance: "10.0000000",
assetType: "credit_alphanum4" as const,
assetCode: "DUP",
assetIssuer: "GISSUER11111111111111111111111111111111111111111111",
};

const duplicateAsset2 = {
asset: "DUPLICATE_ASSET",
balance: "20.0000000",
assetType: "credit_alphanum4" as const,
assetCode: "DUP",
assetIssuer: "GISSUER22222222222222222222222222222222222222222222",
};

vi.mocked(useSorokit).mockReturnValue({
balances: [duplicateAsset1, duplicateAsset2],
isLoadingAccount: false,
isConnected: true,
} as unknown as ReturnType<typeof useSorokit>);

render(<BalanceList />);

const duplicateWarnings = consoleSpy.mock.calls.filter(([msg]) =>
typeof msg === "string" && msg.includes("same key")
);

expect(duplicateWarnings).toHaveLength(0);
consoleSpy.mockRestore();
});
});
});
4 changes: 2 additions & 2 deletions src/components/BalanceList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ export function BalanceList({ onAssetClick, detailRef }: BalanceListProps) {
</div>
) : (
<div>
{sorted.map((b) => (
{sorted.map((b, idx) => (
<AssetRow
key={b.asset}
key={`${b.assetType}-${b.assetCode ?? b.asset}-${b.assetIssuer ?? idx}`}
b={b}
onClick={onAssetClick ? () => handleAssetClick(b) : undefined}
/>
Expand Down