feat: expand AssetBadge colors with deterministic fallback for unknown - #628
Open
dinahmaccodes wants to merge 5 commits into
Open
feat: expand AssetBadge colors with deterministic fallback for unknown#628dinahmaccodes wants to merge 5 commits into
dinahmaccodes wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
@dinahmaccodes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Incorporated expanded AssetBadge colors (yXLM, AQUA, SHX, BLND) - Added deterministic fallback color for unknown tokens - Updated KNOWN_ASSETS set with new colors - Preserved enhanced getAssetColor function with color map support - Added onOpenModal callback test for WalletConnectButton - Retained main branch improvements to InfoCell and screen components Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Fixed 4 issues spanning component color improvements, code deduplication, and test coverage:
#562: Expanded AssetBadge color palette to include yXLM, AQUA, SHX, and BLND with distinct colors. Implemented deterministic hash-based color fallback for unknown tokens so they no longer appear grey.
#561: Extracted duplicate InfoCell helper component into a shared reusable component at src/components/ui/InfoCell.tsx used by both WalletScreen and NetworkScreen.
#560: Added test for onOpenModal callback when clicking connected address pill.
#559: BalanceList tests already comprehensive (no changes needed).
Checklist
#562 - yXLM, AQUA, SHX, BLND have distinct explicit colors
#562 - Unknown tokens get deterministic color based on hash (not grey)
#562 - Two different unknown tokens get visually distinct colors
#562 - Grey fallback completely removed
#561 - InfoCell extracted to src/components/ui/InfoCell.tsx
#561 - Both WalletScreen and NetworkScreen import shared InfoCell
#561 - InfoCell supports label, value, mono, copyable, and className props
#561 - Visual output unchanged after refactor
#561 - InfoCell exported from src/components/index.ts
#560 - Test verifies onOpenModal is called on address pill click
#560 - All WalletConnectButton tests pass (7 tests)
#559 - BalanceList tests comprehensive and passing (14 tests)
All tests passing: 21 AssetBadge tests, 21 WalletConnectButton/BalanceList tests
Closes
Closes #562
Closes #561
Closes #560
Closes #559