test(history): cover pagination, address-change reset, loading and error in TransactionHistory (Closes #554) - #630
Open
BernardOnuh wants to merge 1 commit into
Open
test(history): cover pagination, address-change reset, loading and error in TransactionHistory (Closes #554)#630BernardOnuh wants to merge 1 commit into
BernardOnuh wants to merge 1 commit into
Conversation
…nge reset, loading and error (Sorokit#554) - Rewrite the stale (Sorokit#525) regression test: sessionStorage page-restore was removed (fc66b90), so it now asserts a page reached for one address never leaks into the next account's requests - Add TransactionHistory.provider.test.tsx rendering the component inside a real SorokitContext (mock SorokitProvider), covering page-1 initial fetch, rendered rows, loading skeleton, Prev disabled on page 1, Next -> page 2, fetch-error message, address-change reset to page 1, and the connect-your-wallet empty state
BernardOnuh
changed the title
|
@BernardOnuh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #554.
What
TransactionHistory.provider.test.tsx(new) — rendersTransactionHistoryinside a realSorokitContextvia aMockSorokitProvider(nouseSorokitmodule mock), exercising the component's actual hook path:N shown)TransactionHistory.test.tsx— rewrites the stale#525regression test. Page restore viasessionStoragewas removed infc66b90(and#578/240a4ffreset page state on address change), so the old assertion (restore "page 3 of 3") can never hold. It now asserts the live regression contract: a page reached for one address never leaks into the requests issued for a subsequent address.Verification
npx vitest run src/components/TransactionHistory.test.tsx src/components/TransactionHistory.provider.test.tsx→ 42 passednpx eslint <both files>→ cleanmain): 189 failing tests across 23 files and theTransactionHistory.tsxunuseduseRefimport lint error — untouched.Expected behaviors verified against the component:
fc66b90/240a4ff)totalPages > 1