test(events): cover mount fetch, contractId propagation and polling lifecycle for ContractEventFeed (Closes #558) - #631
Open
BernardOnuh wants to merge 1 commit into
Open
Conversation
…resume for ContractEventFeed (Closes Sorokit#558)
|
@BernardOnuh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #558.
What
Adds the two acceptance-criteria behaviors that
ContractEventFeed.test.tsxwas still missing. The file already covered list rendering, empty state, error state, initial-load skeleton, and pausing polling — so this PR fills the remaining gaps:fetches events on mount with the contractId and the default limit— asserts the first call lands on mount with(CONTRACT_ID, 10, undefined)and fires exactly once, locking in the initial-fetch contract from the issue's Problem statement.restarts polling when the Live/Paused toggle is turned back on— pauses (no new calls after advancing well past the interval), then resumes and verifies one new call fires per poll interval. The issue explicitly calls out "Live toggle stops and restarts polling"; only the stop half had tests.Verification
npx vitest run src/components/ContractEventFeed.test.tsx→ 35/38 pass; the 3 failures are the pre-existing JSON export (test: BalanceList search filter and sort modes, TransactionHistory status filter API params, ContractEventFeed export and topic copy #352) tests, which fail identically on cleanmain(verified viagit stash) and are unrelated to this change.npx eslint src/components/ContractEventFeed.test.tsx→ clean.The polling tests drive
vi.useFakeTimers()+vi.advanceTimersByTime()against the component'ssetInterval(load, pollInterval)wiring.