test(address-display): deterministic copied-state reset coverage (Closes #556) - #632
Open
BernardOnuh wants to merge 1 commit into
Open
test(address-display): deterministic copied-state reset coverage (Closes #556)#632BernardOnuh wants to merge 1 commit into
BernardOnuh wants to merge 1 commit into
Conversation
|
@BernardOnuh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #556.
What
AddressDisplay.test.tsxalready covered the bulk of this issue's acceptance criteria — default truncation viatruncateAddress,showFull, clipboard invocation with the full address, the immediate "Address copied" label, the#534non-secure-context fallbacks (navigator.clipboardundefined / rejecting / both methods failing). The one criterion not pinned down deterministically was the 2-second reset: only an implicit ~2.5s real-timewaitForin the first test exercised it.This PR adds a
copied state reset (#556)describe with two fake-timer tests:keeps 'Address copied' until the 2s timeout, then resets— asserts the label flips immediately on copy, is still "Address copied" one millisecond before the 2s window elapses, and returns to "Copy address to clipboard" the instant it elapses (exact boundary, no wall-clock waiting).resets the 2s window when copy is triggered again mid-window— re-copying while already in the copied state clears the pendingCOPIED_RESET_MStimer (clearResetTimer) and starts a fresh full 2s window; verifies the label survives a second near-full window and resets only after the renewed deadline.Verification
npx vitest run src/components/AddressDisplay.test.tsx→ 27 passed (25 existing + 2 new).npx eslint src/components/AddressDisplay.test.tsx→ clean.