fix: wire soroban client adapter to replace unimplemented stubs and type invokeContract - #639
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
invokeContractparameters to use the typedInvokeParamsinterface instead ofany.getEventsreturning valid contract event payloads forContractEventFeed.TODOcomments and error stubs ({ error: 'Not implemented' }).Why It Was Needed
SorobanPanelfailed with a "Not implemented" error stub.ContractEventFeedreceived anullpayload by default, preventing events from rendering in the UI.anyparameter typing oninvokeContractbypassed TypeScript safety.Implementation Details
soroban.invokeContractnow processes typedInvokeParams(contractId,method,args,sourceAccount).soroban.getEventsreturns structuredContractEventrecords (id,type,ledger,topics,value,createdAt).main.tsxviacreateMockClient()/SorokitClient.Verification
SorobanPanelandContractEventFeedintegration.anycasts in the adapter.Closes #574