fix: combine error states in SorokitProvider and conditionally render Dashboard screens (#583, #585) - #647
Merged
k-deejah merged 2 commits intoSep 2, 2026
Conversation
…conditionally render Dashboard screens (Sorokit#583, Sorokit#585)
|
@Olamidepy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Merge @k-deejah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves two issues affecting state management and rendering lifecycle:
Promise.alland ensures errors are cleared on wallet reconnect or disconnect inSorokitProvider.Dashboardto prevent redundant data fetching and interval leaks.Why These Changes Were Needed
1.
SorokitProviderError Handling (#583)getAccountandgetBalancesran inPromise.all. If both operations encountered an error, the second call'ssetErrorsilently overwrote the first, displaying only one partial error to the user.TopBar.2.
DashboardPre-Mounting Screens (#585)Dashboard.tsxpreviously defined screens in a module-level constant map (SCREENS). This caused all 5 screens (and their respective child hooks likeTransactionHistory,FeeEstimator,ClaimableBalanceCard, andContractEventFeed) to mount and execute data fetching immediately upon app startup.What Was Changed & How It Was Implemented
src/context/SorokitProvider.tsxsetError(null)at the beginning of theaddressuseEffecthook so stale errors are cleared prior to starting new fetches.Promise.allresolution, joined non-null error strings using a semicolon delimiter (;):