Repository navigation
fix(obsws): clear errors for a missing OBS password or challenge - #72
Merged
Merged
Conversation
The WebSocket password was an empty string both when OBS asks for none and when it asks for one that isn't saved. It is now None when OBS's server doesn't ask for one, and a server that asks with no saved password is reported as soon as its settings are read. A Hello that asks for a password without its salt or challenge used to get a proof built from empty text, which OBS can only refuse with an unclear close code. It now fails with a message saying so. Also clears CodeQL's two rust/hard-coded-cryptographic-value alerts on shipping code (the empty fallbacks flowed into the password proof).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 0.1.15, from CodeQL's
rust/hard-coded-cryptographic-valuealerts onsrc/integrations/obsws.rs.Option.Nonewhen OBS's WebSocket server doesn't ask for one. A server that asks for a password that isn't saved is now reported when its settings are read, instead of at connect time.Both new error paths are covered by tests. The remaining alerts from that rule are test fixtures (
#[cfg(test)], the obs-websocket protocol example, the password-hash vectors) and are not changed here.Test:
cargo test obsws