feat: add NFT Marketplace contract with auctions, offers, and royalty enforcement - #63
Merged
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Summary
Implements a comprehensive NFT marketplace module enabling P2P NFT trading, English and Dutch auctions, royalty enforcement, and collection management with integrated payment settlement.
Changes
New Contract (
contracts/nft-marketplace/)Shared Crate Updates
nft_listed,nft_sold,nft_bid,nft_auction,nft_settle,nft_offer,royalty_paid,collection_registered)Key Design Decisions
MarketErrorenum — Soroban's#[contracterror]macro limits enums to 50 variants; marketplace errors live in their own enum to avoid exceeding the shared crate's limitcurrent_bidderuses the contract's own address as a "no bids yet" placeholder, checked viacurrent_bid > 0Test Coverage
31 unit tests covering:
Acceptance Criteria