fix(home): rebuild warn-dirty fix + deps bump + help on wrapper commands#11
Merged
Merged
Conversation
The newer nixos-rebuild-ng has a strict argparse and rejects nix's --no-warn-dirty passthrough that the old Perl nixos-rebuild forwarded to nix build. Use the --option warn-dirty false form it does forward instead. warn-dirty is also set declaratively (nix.settings.warn-dirty = false), so this only matters for a rebuild run before that lands in /etc/nix/nix.conf. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Routine input bump picked up by the rebuild flow's nix flake update step (construct == skills sync). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Mirror `construct help`: each wrapper takes an optional `help` positional. `skills-sync help` / `skills-ship help` forward to `construct skill {sync,ship} --help`; `rebuild help` runs `help rebuild`. Any other stray positional is rejected with a hint (keeps fail-fast on typos); no-arg behavior is unchanged. Region parses clean under `nu`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands two commits that were stranded on
refactor/tier2— pushed there but never reachedmain, because PR #10 was squash-merged before they were made — plus one small new affordance.Commits
fix(home): rebuild uses --option warn-dirty false (nixos-rebuild-ng)—main'srebuildcurrently passes--no-warn-dirty, which nixos-rebuild-ng's strict argparse rejects, sorebuildfails outright onmain. Uses the--option warn-dirty falseform it does forward instead. (Your commit, cherry-picked onto currentmain.)chore(deps): bump construct + gitway flake inputs— cherry-picked as-is.feat(home): add help to skills-sync, skills-ship, rebuild— mirrors the now-fixedconstruct help.skills-sync help/skills-ship helpforward toconstruct skill {sync,ship} --help;rebuild helprunshelp rebuild. A stray non-helppositional is rejected with a hint (keeps fail-fast on typos); no-arg behavior is unchanged.Verification
origin/main— no conflicts; Tier-2 content is already inmainvia squash2bc5a49.nu.construct helpfix shipped separately to Constructmain(9db6bd9): dropsdisable_help_subcommand, adds black-box tests; fullcargogate (build / clippy-D warnings/ test / fmt) green.🤖 Generated with Claude Code