build(justfile): mirror CI's audit advisory ignores in just audit#40
Merged
Conversation
CI's cargo-audit job ignores RUSTSEC-2024-0436 (paste, unmaintained) and RUSTSEC-2026-0002 (lru, unsound) — both warning-class, transitive via the ratatui tree. Plain `cargo audit` exits 0 on these (they're warnings, not vulnerabilities), so `just ci` did not fail — but it printed advisories CI suppresses, diverging from the "mirrors CI" intent and relying on cargo-audit's default warning-vs-fail behavior. Pass the same `--ignore` list as CI's audit-check `ignore:` input so local output matches the runner and stays robust if cargo-audit ever escalates warnings. Kept in lock-step with .github/workflows/ci.yml. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a review note on the
justfile(PR #39):just auditran plaincargo audit, which doesn't carry CI's accepted advisory ignores.Accuracy note
The finding's stronger claim — that
just cifails locally — isn't correct:RUSTSEC-2024-0436(paste, unmaintained) andRUSTSEC-2026-0002(lru, unsound) are warning-class advisories, socargo auditexits 0 (verified).just cipassed. What was real is the milder issue: local output showed two advisories that CI'srustsec/audit-check@v2suppresses via itsignore:input — a divergence from "mirrors CI exactly," and a reliance on cargo-audit's default warning-vs-fail behavior.Fix
just auditnow passes--ignore RUSTSEC-2024-0436 --ignore RUSTSEC-2026-0002, mirroring the CI audit job'signore:list (kept in lock-step with.github/workflows/ci.yml). Output now matches the runner's clean run and is robust if cargo-audit ever escalates warnings to failures.Verified:
just auditscans clean and exits 0;just --listrenders cleanly. justfile-only — CI jobs (which invoke the cargo commands directly, notjust) are unaffected.🤖 Generated with Claude Code