Skip to content

style(bios): rustfmt M1-16 Path B sources (fix CI fmt failure on main)#2

Merged
UnbreakableMJ merged 2 commits into
mainfrom
m1-16-path-b
Apr 28, 2026
Merged

style(bios): rustfmt M1-16 Path B sources (fix CI fmt failure on main)#2
UnbreakableMJ merged 2 commits into
mainfrom
m1-16-path-b

Conversation

@UnbreakableMJ

Copy link
Copy Markdown
Collaborator

Follow-up to #1: applies `cargo fmt --all` to the four M1-16 Path B
source files where rustfmt diffs were flagged after the merge.
`fmt` is now clean locally; should unblock the rest of the
`ci` matrix on `main`.

No semantic changes — trailing-comment alignment plus a few wraps.

🤖 Generated with Claude Code

Re-flows trailing comments and wraps the CI fmt job flagged on PR #1.
No semantic changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@UnbreakableMJ has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 43 minutes and 13 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3b93c205-5833-4af0-9a65-c47223ee375d

📥 Commits

Reviewing files that changed from the base of the PR and between b8899fb and 3cfcc9f.

📒 Files selected for processing (5)
  • zamak-bios/src/boot_bundle.rs
  • zamak-bios/src/entry.rs
  • zamak-bios/src/main.rs
  • zamak-bios/src/rm_io.rs
  • zamak-core/src/ram_fat32.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch m1-16-path-b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

CI clippy flagged four lints in the new walker:
- `manual_range_contains` × 2 → `(2..FAT32_END_OF_CHAIN).contains(&cluster)`
  / `!(2..FAT32_END_OF_CHAIN).contains(&cluster)`.
- `manual_is_ascii_check` × 2 → `is_ascii_uppercase` / `is_ascii_lowercase`.

Plus an `identity_op` (`x + 0x00`) in the LFN test fixture and
the rustfmt re-flow that came with replacing the longer literals.

No semantic change; 9/9 host walker tests + bios-boot-smoke all
still pass locally.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@UnbreakableMJ UnbreakableMJ merged commit f434aa6 into main Apr 28, 2026
16 checks passed
@UnbreakableMJ UnbreakableMJ deleted the m1-16-path-b branch April 28, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant